save.js ➔ ... ➔ ??? - Code Metrics - Inspection of "Merge pull request #25 from AdFabConnect/refactor_..." - AdFabConnect/abejs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 430c18...52d1c6 )

unknown

created 2016-11-07 15:57 UTC

save.js ➔ ... ➔ ??? C

↳ Parent: Project

Complexity

Conditions	10
Paths	10

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
nc	10
dl	0
loc	23
rs	5.6534
c	0
b	0
f	0
cc	10
nop	1

1 Function

Rating	Name	Duplication	Size	Complexity
A	save.js ➔ saveHtml	0	6	1

How to fix Complexity

import fse from 'fs-extra'
import mkdirp from 'mkdirp'
import xss from 'xss'
import path from 'path'

import {
  config
} from '../../'

export function saveJson(url, json) {
  mkdirp.sync(path.dirname(url))

  if(typeof json.abe_source !== 'undefined' && json.abe_source !== null) {
    delete json.abe_source
  }

  var eachRecursive = function (obj) {
    for (var k in obj) {
var someObject;
for (var key in someObject) {
    if ( ! someObject.hasOwnProperty(key)) {
        continue; // Skip keys from the prototype.
    }

    doSomethingWith(key);
}
      if (typeof obj[k] === 'object' && obj[k] !== null){
        eachRecursive(obj[k])
      } else if (typeof obj[k] !== 'undefined' && obj[k] !== null){
        obj[k] = xss(obj[k].toString().replace(/&quot;/g, '"'), { 'whiteList': config.htmlWhiteList })
      }
    }
  }

  eachRecursive(json)

  fse.writeJsonSync(url, json, {
    space: 2,
    encoding: 'utf-8'
  })
  return true
}

export function saveHtml(url, html) {
  mkdirp.sync(path.dirname(url))
  fse.writeFileSync(url, html)

  return true
}

1			import fse from 'fs-extra'
2			import mkdirp from 'mkdirp'
3			import xss from 'xss'
4			import path from 'path'
5
6			import {
7			config
8			} from '../../'
9
10			export function saveJson(url, json) {
11			mkdirp.sync(path.dirname(url))
12
13			if(typeof json.abe_source !== 'undefined' && json.abe_source !== null) {
14			delete json.abe_source
15			}
16
17			var eachRecursive = function (obj) {
18			for (var k in obj) {
			0 ignored issues – show Complexity introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report A for in loop automatically includes the property of any prototype object, consider checking the key using `hasOwnProperty`. When iterating over the keys of an object, this includes not only the keys of the object, but also keys contained in the prototype of that object. It is generally a best practice to check for these keys specifically: var someObject; for (var key in someObject) { if ( ! someObject.hasOwnProperty(key)) { continue; // Skip keys from the prototype. } doSomethingWith(key); } Loading history...
19			if (typeof obj[k] === 'object' && obj[k] !== null){
20			eachRecursive(obj[k])
21			} else if (typeof obj[k] !== 'undefined' && obj[k] !== null){
22			obj[k] = xss(obj[k].toString().replace(/"/g, '"'), { 'whiteList': config.htmlWhiteList })
23			}
24			}
25			}
26
27			eachRecursive(json)
28
29			fse.writeJsonSync(url, json, {
30			space: 2,
31			encoding: 'utf-8'
32			})
33			return true
34			}
35
36			export function saveHtml(url, html) {
37			mkdirp.sync(path.dirname(url))
38			fse.writeFileSync(url, html)
39
40			return true
41			}

AdFabConnect / abejs

Push — master ( 430c18...52d1c6 )

save.js ➔ ... ➔ ??? C

Complexity

Size

Duplication

Importance

1 Function

How to fix Complexity

Complexity

Duplication Side-by-Side

Filter issues like